Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor initial scan Vulnerability E2E Tests #5081

Merged
merged 9 commits into from
Mar 8, 2024

Conversation

Rebits
Copy link
Member

@Rebits Rebits commented Mar 6, 2024

Description

This PR incorporates numerous fixes for the InitialTests scan of the VD module following the recent breaking changes introduced in the system.

List of changes

  • Removed initial tests related to alert generation to streamline functionality.
  • Insured consistency between first and second scan tests to prevent errors stemming from score discrepancies.
  • Addressed various style errors and included enhancements to minor logging features.

Testing performed

Normal execution report

Note

Only the InitialScan with a restricted number of agents was tested

Forcing error report

To ensure accurate reporting of failed behaviors as expected, we've adjusted the results of the first scan during testing, deliberately causing some tests to fail.

@Rebits Rebits self-assigned this Mar 6, 2024
@Rebits Rebits linked an issue Mar 6, 2024 that may be closed by this pull request
@Rebits Rebits marked this pull request as ready for review March 6, 2024 19:34
@rafabailon rafabailon self-requested a review March 7, 2024 08:15
Copy link
Member

@rafabailon rafabailon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidjiglesias davidjiglesias merged commit c4f11a6 into 4.8.0 Mar 8, 2024
4 of 5 checks passed
@davidjiglesias davidjiglesias deleted the fix/5050-refactor-vd-e2e-initial-scan branch March 8, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor InitialScan Vulnerability Detection E2E tests
3 participants